This is a discussion on ★GmR Game | [v19] | Second Server [ BAR STREET ] Coming Soon !!! within the Private Servers forums, part of the Knight Online (ko4life.com) category; Originally Posted by twostars
Yeah, you guys are real geniuses.
imgur: the simple image sharer
I should go dig up ...
With 3 (or more?) of you hacking around with it, you proceeded to only make things worse (by removing the entire locking mechanism which guarded against race conditions).
The only reason it ever got fixed was because I gave in and fixed it for you FFS. I tried to get you to see it for yourself, but all you ever did was pass blame and say "my codes were wrong", much as you're doing right now.
Such strong code, but hey, immediately down my throat for your next unsolvable issue, in the comments for the commit which fixed the first problem. Ugh.
Bloody geniuses, the lot of you.
I said you are really talented developer. But You dont know the details of the game . I'm trying to explain this.
I've seen some really bad stuff in my life but seeing monkeys code was uhh....
I'm sure Two will explain what you had in mind,but this is either way a simple database fix.
If you are referring to fixing the bugs from the database i'm more than sure you'll have a bad time.
Having said that, bearing in mind there's been no changes to existing type 4 skills for an awful long time (aside from additions for new skill buffs), it seems to work fine here:
Edit: It also reset correctly after it expired, if that's what was being referred to (reading WestUS's post):
It's intended to stack AC amounts and take them back, rather than resetting the entire amount; anything added gets removed.
This is typical behaviour even back then.Code:case BUFF_TYPE_AC: if (pType->sAC == 0 && pType->sACPct > 0) pTarget->m_sACPercent -= (pType->sACPct - 100); else pTarget->m_sACAmount -= pType->sAC; break;
If I had to guess, that bug was a result of your early magic system changes that turned our pretty clean & concise logic into something incomprehensible, for the sake of purposely introducing a bug with canceling of max HP scrolls. It'd be interesting to find out, but it'd fit since all that stuff screwed horribly with buff logic.